cleanup: better logging for device & type, use Kingpin to check values #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
k0ste
force-pushed
the
help2
branch
3 times, most recently
from
f9814ba to
aac4901
Compare
This was referenced Apr 25, 2025
…n values * use kingpin to check `smartctl.powermode-check` option value * better help message for `smartctl.powermode-check` with possible values * better logging labels, with device name & type, without device path Signed-off-by: Konstantin Shalygin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smartctl.powermode-checkoption valuesmartctl.powermode-checkwith possible values